Skip to content

Add filtering and sorting to exported results#1766

Merged
koesie10 merged 5 commits intomainfrom
koesie10/export-results-sorting-filtering
Nov 16, 2022
Merged

Add filtering and sorting to exported results#1766
koesie10 merged 5 commits intomainfrom
koesie10/export-results-sorting-filtering

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Nov 15, 2022

Please review this PR commit-by-commit. This adds filtering and sorting to exported results and creates a separate directory for every export since they can now be different in which files they produce (and is not merely additive).

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This adds filtering (based on search and selected repositories) and
sorting to exporting results. This is done in the same way as for
copying the repository list, so the changes are fairly minimal.
Each variant analysis export can be different due to different filters,
so there are two options:
- We need to clean up the directory before each export to ensure no old
  files are left
- We need to use a separate directory for each export

This implements the second option, which is more flexible and allows the
user to retain different result exports.
Base automatically changed from koesie10/export-results-from-view to main November 15, 2022 15:02
@koesie10 koesie10 changed the base branch from main to koesie10/selected-copy November 15, 2022 15:14
@koesie10 koesie10 marked this pull request as ready for review November 15, 2022 15:56
@koesie10 koesie10 requested review from a team as code owners November 15, 2022 15:56
Base automatically changed from koesie10/selected-copy to main November 16, 2022 17:41
@koesie10 koesie10 enabled auto-merge November 16, 2022 17:47
@koesie10 koesie10 merged commit 6219b43 into main Nov 16, 2022
@koesie10 koesie10 deleted the koesie10/export-results-sorting-filtering branch November 16, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants