Skip to content

Don't show pending state when analysis has failed#1808

Merged
robertbrignull merged 2 commits intomainfrom
robertbrignull/failed_analysis_pending
Nov 30, 2022
Merged

Don't show pending state when analysis has failed#1808
robertbrignull merged 2 commits intomainfrom
robertbrignull/failed_analysis_pending

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

If a variant analysis fails because there are no repos to query (or the repos don't have databases) then it doesn't get as far as creating an actions workflow. This means that using the presence of that field alone is problematic for determining the status of a variant analysis.

This PR will avoid cases like:
Screenshot 2022-11-25 at 16 29 11

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team as a code owner November 29, 2022 15:04
@robertbrignull
Copy link
Copy Markdown
Contributor Author

I briefly forgot tests exist, but I'll try to write some that cover this.

@robertbrignull
Copy link
Copy Markdown
Contributor Author

There weren't any existing tests of the logic in this component, which is understanding as it's the top-level component and there isn't much logic in it itself beyond delegating to other component. So I've added tests about showing a pending analysis and this specific case of an analysis that failed because there were no repos to query. I've avoided going further than that to avoid this PR getting out of control.

@robertbrignull robertbrignull merged commit 45a8719 into main Nov 30, 2022
@robertbrignull robertbrignull deleted the robertbrignull/failed_analysis_pending branch November 30, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants