Don't show pending state when analysis has failed#1808
Merged
robertbrignull merged 2 commits intomainfrom Nov 30, 2022
Merged
Conversation
Contributor
Author
|
I briefly forgot tests exist, but I'll try to write some that cover this. |
Contributor
Author
|
There weren't any existing tests of the logic in this component, which is understanding as it's the top-level component and there isn't much logic in it itself beyond delegating to other component. So I've added tests about showing a pending analysis and this specific case of an analysis that failed because there were no repos to query. I've avoided going further than that to avoid this PR getting out of control. |
koesie10
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a variant analysis fails because there are no repos to query (or the repos don't have databases) then it doesn't get as far as creating an actions workflow. This means that using the presence of that field alone is problematic for determining the status of a variant analysis.
This PR will avoid cases like:

Checklist
ready-for-doc-reviewlabel there.