Skip to content

Show selected item in new DB panel#1824

Merged
shati-patel merged 2 commits intomainfrom
shati-patel/decoration-provider
Dec 2, 2022
Merged

Show selected item in new DB panel#1824
shati-patel merged 2 commits intomainfrom
shati-patel/decoration-provider

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Dec 1, 2022

Adds a FileDecorationProvider which displays a ✔ label next to the selected item in the new DB panel. E.g.

selected item in DB panel

It currently doesn't have any clicky UI actions, but that will come in a follow-up issue!

Note: I'm not sure if/how to test this "file decoration". I'm wondering whether to wait until we have UI actions too, but I'm open to other suggestions about tests!

Checklist

N/A - internal only 🦑

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Base automatically changed from charisk/selected-db-state to main December 1, 2022 16:27
@shati-patel shati-patel force-pushed the shati-patel/decoration-provider branch from 8c2e511 to 9ef8283 Compare December 2, 2022 10:31
@shati-patel shati-patel marked this pull request as ready for review December 2, 2022 10:37
@shati-patel shati-patel requested review from a team as code owners December 2, 2022 10:37
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 , just a comment around where the logic goes.

I don't think we need to write any further tests - I already covered some of this logic in the previous PR.

Comment thread extensions/ql-vscode/src/extension.ts Outdated
@shati-patel shati-patel merged commit 8b35435 into main Dec 2, 2022
@shati-patel shati-patel deleted the shati-patel/decoration-provider branch December 2, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants