Create method that returns selected DbItem#1830
Merged
norascheuch merged 7 commits intomainfrom Dec 6, 2022
Merged
Conversation
charisk
reviewed
Dec 5, 2022
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
This is great, thank you! Love seeing all the tests too.
norascheuch
force-pushed
the
nora/selected-db-item
branch
from
c08ad4b to
7a2f976
Compare
charisk
approved these changes
Dec 5, 2022
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Thanks for making the changes and thinking about readability.
…on.test.ts Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a query we need to know which DbItem is selected in the new DB panel. This PR adds a method to the DbManager that returns the currently selected item.
Checklist
ready-for-doc-reviewlabel there.