Skip to content

Update README.md to clarify that vscode-codeql also installs 'Test Adapter Converter' and 'Test Explorer UI'#1831

Merged
aeisenberg merged 4 commits intogithub:mainfrom
darkred:Update-README
Dec 5, 2022
Merged

Update README.md to clarify that vscode-codeql also installs 'Test Adapter Converter' and 'Test Explorer UI'#1831
aeisenberg merged 4 commits intogithub:mainfrom
darkred:Update-README

Conversation

@darkred
Copy link
Copy Markdown
Contributor

@darkred darkred commented Dec 3, 2022

This is a follow-up of my suggestion in #1542 (comment) (cc @aeisenberg).
It adds a clarification in README.md that two additional extensions are installed, being dependencies required for proper functionality.
This PR changes both README.md files, as my suggestion is to also include this clarification in the Marketplace page, as well as in the 'Details' tab of the VSCode's Extensions panel.

The markdown changes rendered:

Repo README.md

2022-12-04_010056

Marketplace README.md

2022-12-04_012924

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@darkred darkred requested a review from a team as a code owner December 3, 2022 23:06
@darkred darkred changed the title Update README.md Update README.md to clarify that vscode-codeql also installs 'Test Adapter Converter' and 'Test Explorer UI' Dec 3, 2022
Comment thread README.md Outdated
Comment thread extensions/ql-vscode/README.md Outdated
@aeisenberg
Copy link
Copy Markdown
Contributor

Thanks for the PR. I'm going to do a little copy-editing here and then merge.

@aeisenberg aeisenberg merged commit 127baea into github:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants