Skip to content

Track parent list name for db items#1833

Merged
charisk merged 1 commit intomainfrom
charisk/parent-list-name
Dec 5, 2022
Merged

Track parent list name for db items#1833
charisk merged 1 commit intomainfrom
charisk/parent-list-name

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Dec 5, 2022

Db items that represent databases inside user defined lists (local or remote), currently don't keep any information about their parent. This makes it a bit difficult to work out the details needed to update the selected db item through the UI.

In this change we add some knowledge to LocalDatabaseDbItem and RemoteRepoDbItem to keep track of their parent.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Dec 5, 2022
@charisk charisk requested a review from a team as a code owner December 5, 2022 10:32
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👪 ✔️

@charisk charisk merged commit 2967777 into main Dec 5, 2022
@charisk charisk deleted the charisk/parent-list-name branch December 5, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants