Fix missing error message on repository selection#1837
Merged
Conversation
The repository selection was structured such that you would get in the `else` case if there was nothing selected, but this case would also be used if for some other reason the selected item was not valid. This restructures the conditions to first check whether the user cancelled out of the operation and will silently return in that case. In other cases where it cannot determine the repositories, it will now show a user-visible error.
elenatanasoiu
approved these changes
Dec 7, 2022
…-empty-repositories
koesie10
force-pushed
the
koesie10/fix-no-error-empty-repositories
branch
from
d5e2c24 to
7fd45ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository selection was structured such that you would get in the
elsecase if there was nothing selected, but this case would also be used if for some other reason the selected item was not valid.This restructures the conditions to first check whether the user cancelled out of the operation and will silently return in that case. In other cases where it cannot determine the repositories, it will now show a user-visible error.
Checklist
ready-for-doc-reviewlabel there.