Add validation for duplicate names in the db config#1867
Merged
Conversation
shati-patel
reviewed
Dec 13, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Just a minor typo so far! (I haven't been to test the behaviour yet, so will hold off on approving until we can take a look together 🙇🏽♀️ )
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds validation for duplicate names in the db config. As part of that we also needed to update the logic that renders errors to allow for 2 different kinds of errors:
a) Ones that the db config is just simply not valid based on the JSON schema
b) Ones that the db config is not valid for other reasons e.g. naming
Please feel free to suggest better names!
Checklist
N/A:
ready-for-doc-reviewlabel there.