Skip to content

Add min length constraints to various properties in the db config schema#1868

Merged
charisk merged 1 commit intomainfrom
charisk/db-config-min-length
Dec 13, 2022
Merged

Add min length constraints to various properties in the db config schema#1868
charisk merged 1 commit intomainfrom
charisk/db-config-min-length

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Dec 13, 2022

This to stop users from entering empty db/db list names etc.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Dec 13, 2022
@charisk charisk requested a review from a team December 13, 2022 16:38
@charisk charisk requested a review from a team as a code owner December 13, 2022 16:38
shati-patel
shati-patel approved these changes Dec 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@charisk charisk enabled auto-merge (squash) December 13, 2022 17:15
@charisk charisk merged commit dc2e17d into main Dec 13, 2022
@charisk charisk deleted the charisk/db-config-min-length branch December 13, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @shati-patel