Skip to content

Enable awaitWriteFinish for the db config file watcher#1872

Merged
charisk merged 1 commit intomainfrom
charisk/file-watcher-wait
Dec 14, 2022
Merged

Enable awaitWriteFinish for the db config file watcher#1872
charisk merged 1 commit intomainfrom
charisk/file-watcher-wait

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Dec 14, 2022

More details in the code comment!

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Dec 14, 2022
@charisk charisk requested a review from a team as a code owner December 14, 2022 15:08
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (Tested locally 🧪 )

@charisk charisk merged commit b1bf82d into main Dec 14, 2022
@charisk charisk deleted the charisk/file-watcher-wait branch December 14, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants