Skip to content

Add unit tests to check codeQLDatabasesExperimental.configError value#1876

Merged
shati-patel merged 2 commits intomainfrom
shati-patel/hide-button-tests
Dec 15, 2022
Merged

Add unit tests to check codeQLDatabasesExperimental.configError value#1876
shati-patel merged 2 commits intomainfrom
shati-patel/hide-button-tests

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

Follow-up to #1866:

  • Slight tweak to the ordering of when we set the context value: 8e6c155
  • Adds two unit tests (one to check the case when the config is valid, and one when it's invalid): 9c9092f

Checklist

N/A - internal only! 🤶🏽

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel requested a review from a team as a code owner December 15, 2022 12:50
@shati-patel shati-patel enabled auto-merge (squash) December 15, 2022 12:53
@shati-patel shati-patel merged commit fecefe4 into main Dec 15, 2022
@shati-patel shati-patel deleted the shati-patel/hide-button-tests branch December 15, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants