Create "Add database" button in DB panel #1889
Merged
norascheuch merged 3 commits intomainfrom Dec 20, 2022
Merged
Conversation
norascheuch
force-pushed
the
shati-nora/add-remote-repositories
branch
from
db4a540 to
c548ee3
Compare
norascheuch
force-pushed
the
shati-nora/add-remote-repositories
branch
from
c548ee3 to
467d43c
Compare
shati-patel
approved these changes
Dec 20, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
This looks great, thanks! ✨ ➕
As we discussed earlier, we'll refine the behaviour in some follow-up PRs:
- Add validation (similar to what we do for the
addNewListfunction) - Support adding a repo to a list directly (depends on #1887)
- Add some tests for the "add owner" and "add repo" functions
charisk
approved these changes
Dec 20, 2022
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
LGTM, thank you @shati-patel and @norascheuch for working together on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To add new databases to the new DB panel we want to have an "Add database" button (using the "add" icon), which lets a user add a new database or an owner item through the UI.
Checklist
ready-for-doc-reviewlabel there.