Skip to content

Use ✓ for db item selection#1890

Merged
charisk merged 1 commit intomainfrom
charisk/use-✓-for-db-selection
Dec 20, 2022

Hidden character warning

The head ref may contain hidden characters: "charisk/use-\u2713-for-db-selection"
Merged

Use ✓ for db item selection#1890
charisk merged 1 commit intomainfrom
charisk/use-✓-for-db-selection

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Dec 20, 2022

Use ✓ for db item selection both in terms of action and decoration.

Screen.Recording.2022-12-20.at.11.13.07.mov

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Dec 20, 2022
@charisk charisk requested review from a team as code owners December 20, 2022 11:15
shati-patel
shati-patel approved these changes Dec 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✔

elenatanasoiu
elenatanasoiu approved these changes Dec 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@elenatanasoiu elenatanasoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✔

@charisk charisk merged commit 4b43b9a into main Dec 20, 2022
@charisk charisk deleted the charisk/use-✓-for-db-selection branch December 20, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shati-patel shati-patel shati-patel approved these changes

+1 more reviewer

@elenatanasoiu elenatanasoiu elenatanasoiu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charisk @elenatanasoiu @shati-patel