Skip to content

Stop user from adding a db or owner with the same name#1893

Merged
charisk merged 1 commit intomainfrom
charisk/add-remote-db-validation
Dec 21, 2022
Merged

Stop user from adding a db or owner with the same name#1893
charisk merged 1 commit intomainfrom
charisk/add-remote-db-validation

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Dec 20, 2022

Follows a similar pattern to the validation checks around db lists.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Dec 20, 2022
@charisk charisk requested a review from a team as a code owner December 20, 2022 20:39
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change! I have two optional suggestions.

Comment thread extensions/ql-vscode/src/databases/db-manager.ts
Comment thread extensions/ql-vscode/src/databases/db-manager.ts
Comment thread extensions/ql-vscode/src/databases/config/db-config-store.ts
@charisk charisk merged commit dbdb4ba into main Dec 21, 2022
@charisk charisk deleted the charisk/add-remote-db-validation branch December 21, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants