Merged
Conversation
shati-patel
reviewed
Dec 21, 2022
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Thanks 🧹 A couple of initial comments, just from poking around locally!
norascheuch
approved these changes
Dec 21, 2022
Contributor
norascheuch
left a comment
There was a problem hiding this comment.
Looks good, thanks for cleaning this up!
norascheuch
approved these changes
Dec 21, 2022
Contributor
norascheuch
left a comment
There was a problem hiding this comment.
Looks good, thanks for cleaning this up!
shati-patel
approved these changes
Dec 21, 2022
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Looks good now, thanks for the fixes 😸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a mixture of validation checks and unhandled exceptions in various places. This PR aims to tidy that up so that:
DbPanel), using error notifications rather than triggering the global error handler.DbConfigStorethrows exceptions in the unlikely event that a caller has asked it to do something that would get the config in an invalid state (e.g. to add a list with an empt name).DbManagershould just pass through without doing the same checks.Checklist
N/A:
ready-for-doc-reviewlabel there.