Add new repositories to a highlighted user defined list#1900
Merged
norascheuch merged 3 commits intomainfrom Dec 22, 2022
Merged
Add new repositories to a highlighted user defined list#1900norascheuch merged 3 commits intomainfrom
norascheuch merged 3 commits intomainfrom
Conversation
norascheuch
commented
Dec 21, 2022
norascheuch
commented
Dec 21, 2022
norascheuch
force-pushed
the
nora/add-repo-to-list
branch
from
5f43f8c to
758c182
Compare
shati-patel
reviewed
Dec 21, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Great! Thanks for adding this ⚡ One comment, and I tried answering your questions (though you might want a more informed opinion 😅)
Comment on lines
+87
to
+89
| if (highlightedItem?.kind === DbItemKind.RemoteUserDefinedList) { | ||
| await this.addNewRemoteRepo(highlightedItem.listName); | ||
| } else { |
Contributor
There was a problem hiding this comment.
From the (internal) issue:
If a list or item inside a list is highlighted, add it to that list
So I think that means something like this? (i.e. also checking if the highlighted item is inside a list)
Suggested change
| if (highlightedItem?.kind === DbItemKind.RemoteUserDefinedList) { | |
| await this.addNewRemoteRepo(highlightedItem.listName); | |
| } else { | |
| if (highlightedItem?.kind === DbItemKind.RemoteUserDefinedList) { | |
| await this.addNewRemoteRepo(highlightedItem.listName); | |
| } else if ( | |
| highlightedItem?.kind === DbItemKind.RemoteRepo && | |
| highlightedItem.parentListName | |
| ) { | |
| await this.addNewRemoteRepo(highlightedItem.parentListName); | |
| } else { |
Contributor
Author
There was a problem hiding this comment.
Oh yes, didn't think about that! Will add the case!
charisk
approved these changes
Dec 21, 2022
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Good stuff, just some suggestions!
shati-patel
approved these changes
Dec 22, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Not sure if you were waiting for another review from me - all looks good :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a remote user defined list is highlighted when pressing the 'Add new Database'-Button we only want to show the option to add a new repository (instead of also adding a new owner) and add the new database to the highlighted list.
Checklist
ready-for-doc-reviewlabel there.