Skip to content

Move test plan into markdown file#1901

Merged
elenatanasoiu merged 23 commits intomainfrom
elena/move-test-scenarios-into-markdown
Dec 22, 2022
Merged

Move test plan into markdown file#1901
elenatanasoiu merged 23 commits intomainfrom
elena/move-test-scenarios-into-markdown

Conversation

@elenatanasoiu
Copy link
Copy Markdown
Contributor

This moves our existing test plan under a "Required testing" section.

We're also adding the scenarios used for testing live results under an "Optional testing" section.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This moves our existing test plan under a "Required testing" section.

We're also adding the scenarios used for testing live results under an "Optional testing" section.
@elenatanasoiu elenatanasoiu force-pushed the elena/move-test-scenarios-into-markdown branch from 5f34b08 to 1e84bc9 Compare December 21, 2022 16:56
@elenatanasoiu elenatanasoiu requested a review from a team as a code owner December 21, 2022 16:56
@elenatanasoiu elenatanasoiu requested a review from a team December 21, 2022 17:13
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Sorry for the large number of comments - it looks like the original test plan was a bit out of date/not structured well enough to take different areas into account so most comments are because of that.

Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
@elenatanasoiu elenatanasoiu changed the title Move test plan into VSCode markdown file Move test plan into markdown file Dec 22, 2022
@elenatanasoiu
Copy link
Copy Markdown
Contributor Author

Golly, this took forever! I've done my best to expand these test cases but there's still room for improvement.

@elenatanasoiu
Copy link
Copy Markdown
Contributor Author

Thanks for the reviews @charisk and @koesie10 !

Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is looking great! Just some nitpicks that you're welcome to ignore!

Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
Comment thread extensions/ql-vscode/docs/test-plan.md Outdated
@elenatanasoiu elenatanasoiu merged commit ae0dfd8 into main Dec 22, 2022
@elenatanasoiu elenatanasoiu deleted the elena/move-test-scenarios-into-markdown branch December 22, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants