Skip to content

Add support for adding local db lists#1907

Merged
charisk merged 1 commit intomainfrom
charisk/add-local-list
Dec 23, 2022
Merged

Add support for adding local db lists#1907
charisk merged 1 commit intomainfrom
charisk/add-local-list

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Dec 22, 2022

Allows adding a new local db list. It shows a quickpick item to select what kind of list to select if nothing is highlighted.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Dec 22, 2022
@charisk charisk requested a review from a team as a code owner December 22, 2022 16:51
@charisk charisk force-pushed the charisk/add-local-list branch from cafb837 to 4228f7b Compare December 22, 2022 16:52
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested locally!

@norascheuch
Copy link
Copy Markdown
Contributor

Special thanks for refactoring readDbConfigDirectly!

@charisk charisk merged commit 24a7348 into main Dec 23, 2022
@charisk charisk deleted the charisk/add-local-list branch December 23, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants