Skip to content

Fix broken unit test that relies on date#1914

Merged
charisk merged 1 commit intomainfrom
charisk/fix-broken-test
Jan 3, 2023
Merged

Fix broken unit test that relies on date#1914
charisk merged 1 commit intomainfrom
charisk/fix-broken-test

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jan 3, 2023

Simple fix for now to unblock other PRs. We will look at what the correct thing to be doing here is separately.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team January 3, 2023 08:51
@charisk charisk requested a review from a team as a code owner January 3, 2023 08:51
norascheuch
norascheuch approved these changes Jan 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@charisk charisk merged commit a7be6cf into main Jan 3, 2023
@charisk charisk deleted the charisk/fix-broken-test branch January 3, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@norascheuch norascheuch norascheuch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @norascheuch