Skip to content

Add test tsconfigs in eslint projects#1916

Merged
charisk merged 1 commit intomainfrom
charisk/fix-eslint-projects
Jan 3, 2023
Merged

Add test tsconfigs in eslint projects#1916
charisk merged 1 commit intomainfrom
charisk/fix-eslint-projects

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jan 3, 2023

Moving the VS Code integration tests (#1912) without adding the project to the eslint config meant that we'd get the following error when running npm run format-staged:

ql-vscode/test/vscode-tests/minimal-workspace/databases/db-panel.test.ts
  0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: test/vscode-tests/minimal-workspace/databases/db-panel.test.ts.
The file must be included in at least one of the projects provided

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Jan 3, 2023
@charisk charisk requested a review from a team January 3, 2023 11:49
@charisk charisk requested a review from a team as a code owner January 3, 2023 11:49
@charisk charisk enabled auto-merge (squash) January 3, 2023 11:55
@charisk charisk merged commit bbdbe01 into main Jan 3, 2023
@charisk charisk deleted the charisk/fix-eslint-projects branch January 3, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants