Merged
Conversation
norascheuch
commented
Jan 3, 2023
| }, | ||
| { | ||
| "command": "codeQLDatabasesExperimental.setSelectedItemContextMenu", | ||
| "title": "Select" |
Contributor
Author
There was a problem hiding this comment.
For want of a better idea I chose just "Select", I could also imagine "Select for running a Query" or "Select current Database" - I'm reluctant with using 'Database' though..
Open for ideas!
norascheuch
commented
Jan 3, 2023
shati-patel
approved these changes
Jan 3, 2023
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Looks good, and works as expected locally 🎉
Just one minor comment about package.json admin, and I've tried to answer your question (but shout if I can explain better!)
Contributor
Author
|
Thanks for the explanation @shati-patel ! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're gradually adding context menu actions for the new DB panel.
Checklist
ready-for-doc-reviewlabel there.