Skip to content

Set db tree item context value to drive actions#1920

Merged
charisk merged 1 commit intomainfrom
charisk/context-value-actions
Jan 3, 2023
Merged

Set db tree item context value to drive actions#1920
charisk merged 1 commit intomainfrom
charisk/context-value-actions

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jan 3, 2023

The various context menu actions that we want to add for the new db panel should only be visible under certain conditions (mostly based on the db item kind). This change updates the contextValue of db tree view items to include strings like canBeSelected, canBeRemoved etc. so that the command can easily check if the action should be allowed for a specific tree view node or not using a regex match.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Jan 3, 2023
@charisk charisk requested review from a team as code owners January 3, 2023 16:01
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@charisk charisk merged commit 8e848e3 into main Jan 3, 2023
@charisk charisk deleted the charisk/context-value-actions branch January 3, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants