Skip to content

Some small refactorings around db item expansion#1923

Merged
charisk merged 6 commits intomainfrom
charisk/db-item-expansion-tidy
Jan 4, 2023
Merged

Some small refactorings around db item expansion#1923
charisk merged 6 commits intomainfrom
charisk/db-item-expansion-tidy

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jan 4, 2023

This change tidies up code around db item expansion. Please check the individual commits for details.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Jan 4, 2023
@charisk charisk requested a review from a team as a code owner January 4, 2023 09:21
This used to be valid when expanded state lived in the db config, but it's now stored in workspace storage.
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🥳

@charisk charisk merged commit 35a49b0 into main Jan 4, 2023
@charisk charisk deleted the charisk/db-item-expansion-tidy branch January 4, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants