Skip to content

Add db and list rename functionality to db config store#1926

Merged
charisk merged 1 commit intomainfrom
charisk/db-config-store-rename
Jan 4, 2023
Merged

Add db and list rename functionality to db config store#1926
charisk merged 1 commit intomainfrom
charisk/db-config-store-rename

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jan 4, 2023

This adds some functions to the db config store to allow renaming of dbs and lists. It's not wired up to anything yet as I thought there's quite a bit of code in here already (mainly test code!)

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Jan 4, 2023
@charisk charisk requested a review from a team as a code owner January 4, 2023 16:07
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚢

Comment thread extensions/ql-vscode/src/databases/config/db-config.ts
@charisk charisk enabled auto-merge January 4, 2023 17:36
@charisk charisk merged commit afc6ce5 into main Jan 4, 2023
@charisk charisk deleted the charisk/db-config-store-rename branch January 4, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants