Skip to content

Minor refactoring for expanded things#1949

Merged
norascheuch merged 4 commits intomainfrom
nora/rename-expanded-methods
Jan 12, 2023
Merged

Minor refactoring for expanded things#1949
norascheuch merged 4 commits intomainfrom
nora/rename-expanded-methods

Conversation

@norascheuch
Copy link
Copy Markdown
Contributor

To improve readability we did some renaming and restructuring.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@norascheuch norascheuch marked this pull request as ready for review January 11, 2023 15:42
@norascheuch norascheuch requested a review from a team as a code owner January 11, 2023 15:42
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind double checking the commits? I'm not sure they look right.

Comment thread extensions/ql-vscode/src/databases/db-item-expansion.ts Outdated
Comment thread extensions/ql-vscode/src/databases/db-manager.ts Outdated
Comment thread extensions/ql-vscode/src/databases/db-manager.ts Outdated
@norascheuch norascheuch force-pushed the nora/rename-expanded-methods branch from 0070887 to 523fa39 Compare January 12, 2023 15:04
@norascheuch norascheuch force-pushed the nora/rename-expanded-methods branch from 523fa39 to 5c40293 Compare January 12, 2023 15:18
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@norascheuch norascheuch merged commit 4ae7735 into main Jan 12, 2023
@norascheuch norascheuch deleted the nora/rename-expanded-methods branch January 12, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants