Convert opening variant analysis logs to a command#1952
Merged
robertbrignull merged 1 commit intomainfrom Jan 11, 2023
Merged
Conversation
charisk
approved these changes
Jan 11, 2023
| await cancelVariantAnalysis(credentials, variantAnalysis); | ||
| } | ||
|
|
||
| public async openVariantAnalysisLogs(variantAnalysisId: number) { |
Contributor
There was a problem hiding this comment.
We could add an integration test for this function, but it doesn't have to be part of this PR.
Contributor
Author
There was a problem hiding this comment.
Good point. I'll look at doing that in a followup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the work for opening the logs for a variant analysis into a command. The primary motivation here is to get telemetry logged for it. The alternative would be outputting telemetry explicitly, but using a command seems cleaner, and makes the code more reusable.
This only affects when opening the logs from the variant analysis results webview. The query history has its own implementation. We could look at unifying these implementations but I think we should wait until the remote queries code has been deleted first.
Checklist
ready-for-doc-reviewlabel there.