Skip to content

Add "describe" blocks around db-panel tests#1965

Merged
shati-patel merged 1 commit intomainfrom
shati-patel/split-test
Jan 16, 2023
Merged

Add "describe" blocks around db-panel tests#1965
shati-patel merged 1 commit intomainfrom
shati-patel/split-test

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Jan 13, 2023

Tidies the db-panel.test.ts file by grouping the tests into describe blocks. Probably best to review this with whitespace hidden 🙈

Next step will probably be to split them into separate files. See internal linked issue 🔗

Checklist

N/A—internal only 🎃

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel requested a review from a team as a code owner January 13, 2023 15:31
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet!

@shati-patel
Copy link
Copy Markdown
Contributor Author

Short and sweet!

Just like me

@shati-patel shati-patel merged commit 817db85 into main Jan 16, 2023
@shati-patel shati-patel deleted the shati-patel/split-test branch January 16, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants