Merged
Conversation
norascheuch
force-pushed
the
nora/rename-db-config-file
branch
from
4bc8875 to
afcb84f
Compare
charisk
reviewed
Jan 16, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Thanks for tidying this up!
Generally LGTM, just have a comment about the JSON validation setup that will need addressing before merging.
Also can you please add a PR description?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
ready-for-doc-reviewlabel there.