Modifying the bump-cli workflow to append/replace version from supported_cli_versions.json#1973
Merged
aeisenberg merged 3 commits intomainfrom Jan 18, 2023
Merged
Conversation
tjgurwara99
force-pushed
the
tjgurwara99/bump-cli-extension
branch
from
4e1df85 to
ed5c5b5
Compare
…upported cli versions
tjgurwara99
force-pushed
the
tjgurwara99/bump-cli-extension
branch
from
ed5c5b5 to
bfa6780
Compare
aeisenberg
reviewed
Jan 16, 2023
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
And I think it can be made even simpler for maintainers to have only a single workflow with an option input. The two options could be "replace" and "prepend". You could add a second job to the bump-cli workflow that runs only when "prepend" is selected. This job could do something similar to what you already wrote.
tjgurwara99
changed the title
bump-cli workflow to append/replace version from supported_cli_versions.json
tjgurwara99
commented
Jan 17, 2023
aeisenberg
reviewed
Jan 18, 2023
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Looks good. I tried it out here and behaved as I expected. Just a suggestion to update the description and then looks good.
aeisenberg
approved these changes
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the development of
bump_cli.ymlworkflow, we understood the requirement that we want to be able to append/prepend/remove versions from versions fromsupported_cli_versions.jsonfile. Initially it was decided that we should modify thebump_cliworkflow, however, the complication I had when doing that was the logic to handle the cases with inputs and without inputs becomes quite complicated and therefore I decided against modifying thebump_cliworkflow. If however, the maintainers really want to just keep one workflow then I can modify this branch and go from there 😄.EDIT: Since the requirements are simplified to replacing and prepending version, we have combined the
bump-cliworkflow andversion-changeworkflow into one workflow.