When adding repo, check whether name exists in specified parent list#1977
Merged
shati-patel merged 2 commits intomainfrom Jan 18, 2023
Merged
When adding repo, check whether name exists in specified parent list#1977shati-patel merged 2 commits intomainfrom
shati-patel merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[in the variant analysis repo panel]
Fixes a bug where you couldn't add a repo to list if that name existed, even outside of that list 🐛
I've now passed in the
parentListto the method that checks for the repo's existence, so that it knows to check inside the correct list. The tests didn't flag this, so I've tweaked one of the existing tests to cover this behaviour in future 🧪Checklist
N/A—internal only 🦀
ready-for-doc-reviewlabel there.