Skip to content

When adding repo, check whether name exists in specified parent list#1977

Merged
shati-patel merged 2 commits intomainfrom
shati-patel/check-repo-list
Jan 18, 2023
Merged

When adding repo, check whether name exists in specified parent list#1977
shati-patel merged 2 commits intomainfrom
shati-patel/check-repo-list

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

[in the variant analysis repo panel]

Fixes a bug where you couldn't add a repo to list if that name existed, even outside of that list 🐛

I've now passed in the parentList to the method that checks for the repo's existence, so that it knows to check inside the correct list. The tests didn't flag this, so I've tweaked one of the existing tests to cover this behaviour in future 🧪

Checklist

N/A—internal only 🦀

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel requested a review from a team as a code owner January 17, 2023 16:39
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shati-patel shati-patel enabled auto-merge (squash) January 17, 2023 16:43
@shati-patel shati-patel merged commit e230bf4 into main Jan 18, 2023
@shati-patel shati-patel deleted the shati-patel/check-repo-list branch January 18, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants