Move tests for serialization/deserialization in their own file#1984
Merged
elenatanasoiu merged 1 commit intomainfrom Jan 18, 2023
Merged
Move tests for serialization/deserialization in their own file#1984elenatanasoiu merged 1 commit intomainfrom
elenatanasoiu merged 1 commit intomainfrom
Conversation
We didn't have a query-serialization.test.ts file. Now we do. We can build on these tests when we begin to save other types of data.
charisk
approved these changes
Jan 18, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Looks good, thanks for tidying that up.
I've assumed this is a copy paste job so haven't looked at the changes too closely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't have a
query-serialization.test.ts file. Now we do.We can build on these tests to check for versioning and saving other types of data.
Checklist
ready-for-doc-reviewlabel there.