Make use of asError instead of reimplementing

[robertbrignull]

This PR updates a few places that were doing their own e instanceOf Error check to instead use asError or getErrorMessage as appropriate.

Also updates the types of the helper methods to be more restrictive, as I believe using unknown instead of any where possible is generally best practice. I haven't gone any further than this with annotating things as unknown to avoid going down too much of a rabbit hole.

Checklist

• CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
• Issues have been created for any UI or other user-facing changes made by this pull request.
• [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

[koesie10]

Thanks for cleaning this up!

[koesie10]

This changes behaviour for the thrown error since the error message now doesn't include Error running query:. The message from the error is probably shown to the user directly since this method is called by a command, so this might change user-facing behaviour as well (depending on if the thrown error is an instance of Error).

[robertbrignull]

Oh your right because asError can just return e instead of a new error, so actually this does edit the existing e which we later throw 🤯

I'll revert this change and leave this file alone.