Merged
Conversation
norascheuch
force-pushed
the
nora/split-query-history-file
branch
from
b2fd01e to
e394749
Compare
shati-patel
approved these changes
Jan 25, 2023
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
LGTM, just a minor name update 🔍
|
|
||
| /** | ||
| * query-history.ts | ||
| * history-tree-data-provider.ts |
Contributor
There was a problem hiding this comment.
Should this be:
Suggested change
| * history-tree-data-provider.ts | |
| * query-history-manager.ts |
Contributor
Author
There was a problem hiding this comment.
good catch, thank you!
| * This text provider lets us open readonly files in the editor. | ||
| * | ||
| * TODO: Consolidate this with the 'codeql' text provider in query-history.ts. | ||
| * TODO: Consolidate this with the 'codeql' text provider in history-tree-data-provider.ts. |
Contributor
There was a problem hiding this comment.
Suggested change
| * TODO: Consolidate this with the 'codeql' text provider in history-tree-data-provider.ts. | |
| * TODO: Consolidate this with the 'codeql' text provider in query-history-manager.ts. |
Contributor
Author
There was a problem hiding this comment.
good catch, thank you!
norascheuch
force-pushed
the
nora/split-query-history-file
branch
from
e394749 to
1f52642
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 class 1 file
Changes are quite superficial, only moving both classes around.
Checklist
ready-for-doc-reviewlabel there.