DP Panel: Drop protocol check when creating a new item#2028
Merged
norascheuch merged 3 commits intomainfrom Feb 1, 2023
Merged
DP Panel: Drop protocol check when creating a new item#2028norascheuch merged 3 commits intomainfrom
norascheuch merged 3 commits intomainfrom
Conversation
shati-patel
approved these changes
Jan 31, 2023
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Looks good! 🎉 Would you mind adding a short PR description?
|
|
||
| it("should handle valid urls", () => { | ||
| expect(getNwoFromGitHubUrl("https://github.com/foo/bar")).toBe("foo/bar"); | ||
| expect(getNwoFromGitHubUrl("http://github.com/foo/bar")).toBe("foo/bar"); |
Contributor
There was a problem hiding this comment.
Could we also add a check for just "github.com/foo/bar"?
Contributor
Author
|
I think the whole requirement is questionable but it should work now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
ready-for-doc-reviewlabel there.