Skip to content

Small tidy-up: Rename test file for databaseFetcher tests#2032

Merged
elenatanasoiu merged 1 commit intomainfrom
shati-elena/check-for-ql-pack
Feb 3, 2023
Merged

Small tidy-up: Rename test file for databaseFetcher tests#2032
elenatanasoiu merged 1 commit intomainfrom
shati-elena/check-for-ql-pack

Conversation

@elenatanasoiu
Copy link
Copy Markdown
Contributor

@elenatanasoiu elenatanasoiu commented Feb 1, 2023 •
edited
Loading

These are not testing anything in the databases.ts file as we're invoking functions from the DatabaseFetcher.

Let's name the file accordingly.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@elenatanasoiu elenatanasoiu force-pushed the shati-elena/check-for-ql-pack branch 2 times, most recently from ec7208d to 3cb3359 Compare February 1, 2023 14:05
@elenatanasoiu elenatanasoiu changed the title Check for QL Pack when opening new database Automatically check for relevant QL packs when adding a new database Feb 1, 2023
@elenatanasoiu elenatanasoiu force-pushed the shati-elena/check-for-ql-pack branch from 3cb3359 to b8503d3 Compare February 1, 2023 14:22
@elenatanasoiu elenatanasoiu force-pushed the shati-elena/check-for-ql-pack branch from b8503d3 to e961997 Compare February 2, 2023 11:30
@elenatanasoiu elenatanasoiu changed the title Automatically check for relevant QL packs when adding a new database Automatically check for language when adding a new database Feb 2, 2023
@elenatanasoiu elenatanasoiu changed the title Automatically check for language when adding a new database Small tidy-up: Rename test file for databaseFetcher tests Feb 2, 2023
@elenatanasoiu elenatanasoiu marked this pull request as ready for review February 2, 2023 16:42
@elenatanasoiu elenatanasoiu requested a review from a team as a code owner February 2, 2023 16:42
shati-patel
shati-patel approved these changes Feb 2, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Thanks for the tidy-up 🧹

@elenatanasoiu
Rename tests for databaseFetcher
6e53ed0 
These are not testing anything in the databases.ts file as we're
invoking functions from the DatabaseFetcher.

Let's name the file accordingly
@elenatanasoiu elenatanasoiu force-pushed the shati-elena/check-for-ql-pack branch from e961997 to 6e53ed0 Compare February 3, 2023 16:21
@elenatanasoiu elenatanasoiu merged commit 9c2aa8c into main Feb 3, 2023
@elenatanasoiu elenatanasoiu deleted the shati-elena/check-for-ql-pack branch February 3, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elenatanasoiu @shati-patel