Add source map support for full stacktraces#2039
Merged
Conversation
This adds support for mapping full stacktraces in the source map script. This allows you to pass a full stacktrace to the script and get back a stacktrace with all original positions.
aeisenberg
approved these changes
Feb 3, 2023
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
I haven't actually tried this out myself, but the code looks generally good. Small suggestion inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for mapping full stacktraces in the source map script. This allows you to pass a full stacktrace to the script and get back a stacktrace with all original positions.
Based on #2037
Example input:
Output:
Checklist
ready-for-doc-reviewlabel there.