Skip to content

Download sourcemaps from release asset if available#2052

Merged
koesie10 merged 4 commits intomainfrom
koesie10/source-map-script-from-release-asset
Feb 8, 2023
Merged

Download sourcemaps from release asset if available#2052
koesie10 merged 4 commits intomainfrom
koesie10/source-map-script-from-release-asset

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Feb 7, 2023

This download download the sourcemaps from the release asset if it is available. Unfortunately, I'm not able to test this yet because we don't yet have any releases with sourcemaps attached. As a fallback, it will still try to download from the workflow run.

Based on #2037

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This download download the sourcemaps from the release asset if it is
available. Unfortunately, I'm not able to test this yet because we don't
yet have any releases with sourcemaps attached. As a fallback, it will
still try to download from the workflow run.
@koesie10 koesie10 requested a review from a team as a code owner February 7, 2023 15:19
Base automatically changed from koesie10/source-map-script to main February 7, 2023 16:37
@koesie10 koesie10 added the secexp label Feb 7, 2023
@koesie10 koesie10 requested a review from a team February 8, 2023 11:15
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

@koesie10 koesie10 enabled auto-merge February 8, 2023 13:31
@koesie10 koesie10 merged commit c71238c into main Feb 8, 2023
@koesie10 koesie10 deleted the koesie10/source-map-script-from-release-asset branch February 8, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants