Conversation
3 tasks
charisk
reviewed
Feb 13, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Sorry I started reviewing last week but got distracted!
Some comments - mostly questions.
The test database is not required for activated extension tests, so we only need to download the test database for CLI integration tests.
This would run the unit, view, integration and CLI integration tests in parallel, which would cause problems with multiple VSCode instances and use a lot of memory.
charisk
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this commit-by-commit.
This creates a new test suite, updates the script names and updates the documentation. The new test suite is essentially the same as the CLI integration test suite, but does not require the CodeQL repository to be added to the workspace and is not run against multiple versions in CI.
Checklist
ready-for-doc-reviewlabel there.