Skip to content

Optimistically update the UI when user selects db/list#2063

Merged
charisk merged 2 commits intomainfrom
charisk/optimistic-ui-update
Feb 13, 2023
Merged

Optimistically update the UI when user selects db/list#2063
charisk merged 2 commits intomainfrom
charisk/optimistic-ui-update

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Feb 10, 2023

This removes the delay between the user selecting a new db/list and the UI updating.

See internal linked issue with more details.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Feb 10, 2023
@charisk charisk requested a review from a team as a code owner February 10, 2023 16:34
@charisk charisk force-pushed the charisk/optimistic-ui-update branch from 824ce2d to e7c0779 Compare February 10, 2023 16:36
}

// Optimistically update the UI to select the item that the user
// to avoid delay in the UI.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a word missing 🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😬

Comment thread extensions/ql-vscode/src/databases/ui/db-tree-data-provider.ts Outdated
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@charisk charisk merged commit ad03dfa into main Feb 13, 2023
@charisk charisk deleted the charisk/optimistic-ui-update branch February 13, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants