Skip to content

Add some better sample env vars in settings.json #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeisenberg merged 2 commits into from
Feb 14, 2023
Merged

Add some better sample env vars in settings.json #2066

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
722f5c5
Add some better sample env vars in settings.json
aeisenberg Feb 10, 2023
d386d42
Add back comment
aeisenberg Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,14 @@
"env": {
"LANG": "en-US",
"TZ": "UTC",

// Uncomment to set a custom path to a CodeQL checkout.
// "TEST_CODEQL_PATH": "../codeql",
Copy link
Copy Markdown
Contributor

@elenatanasoiu elenatanasoiu Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this in launch.json?

Copy link
Copy Markdown
Member

@koesie10 koesie10 Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the launch.json is used when you run the "Launch Integration Tests - With CLI" action using the "Run & Debug" panel of VSCode. These environment variables are instead used when you use the Jest runner to run tests. These are completely separate.


// Uncomment to set a custom path to a CodeQL CLI executable.
// This is the CodeQL version that will be used in the tests.
// "CLI_PATH": "/path/to/customg/codeql",

// Uncomment to debug integration tests
// "VSCODE_WAIT_FOR_DEBUGGER": "true",
}
Expand Down