Remove code to start a remote query run#2068
Merged
Conversation
This removes the `runRemoteQuery` method on the remote queries manager, all code that calls it and code which is now dead.
3 tasks
charisk
approved these changes
Feb 13, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
LGTM. I think we can remove some more code but appreciate we may not want to do that in this PR.
| import { Credentials } from "../common/authentication"; | ||
| import { RepositorySelection } from "./repository-selection"; | ||
| import { Repository } from "./shared/repository"; | ||
| import { RemoteQueriesResponse } from "./gh-api/remote-queries"; |
| import { RepositorySelection } from "./repository-selection"; | ||
| import { Repository } from "./shared/repository"; | ||
| import { RemoteQueriesResponse } from "./gh-api/remote-queries"; | ||
| import { submitRemoteQueries } from "./gh-api/gh-api-client"; |
Contributor
There was a problem hiding this comment.
Shall we clean up gh-api-client as well from remote query related stuff?
Member
Author
|
@charisk Thanks for the review! We can definitely remove a lot more code, but I think it's easier to split it up in more PRs so it can be reviewed more easily. We have a few issues that are related to cleaning up all remote queries code that is remaining after removing the code specified in separate issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
runRemoteQuerymethod on the remote queries manager, all code that calls it and code which is now dead.Checklist
ready-for-doc-reviewlabel there.