Skip to content

Remove remote queries React components #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
koesie10 merged 3 commits into from
Feb 15, 2023
Merged

Remove remote queries React components #2073

koesie10 merged 3 commits into from
Feb 15, 2023

Conversation

@koesie10
Copy link
Member

@koesie10 koesie10 commented Feb 14, 2023 •
edited
Loading

It's probably easiest to review this commit-by-commit:

  • The first commit moves all components that are still used by the variant analysis view out of the remote-queries directory and into a more appropriate directory.
  • The second commit removes all remaining components in remote-queries and the stories for those components

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review February 14, 2023 10:05
@koesie10 koesie10 requested review from a team as code owners February 14, 2023 10:05
charisk
charisk approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@koesie10 koesie10 merged commit a962656 into main Feb 15, 2023
@koesie10 koesie10 deleted the koesie10/remove-remote-queries-react branch February 15, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charisk charisk charisk approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koesie10 @charisk