Skip to content

Cache schema validator for db config #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

Cache schema validator for db config #2092

merged 1 commit into from
Feb 17, 2023

Conversation

@charisk
Copy link
Contributor

@charisk charisk commented Feb 17, 2023

Pre-compile the jSON schema used for validating the db config and cache the validation function.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Feb 17, 2023
@charisk charisk requested a review from a team as a code owner February 17, 2023 13:50
koesie10
koesie10 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charisk charisk merged commit 146f23f into main Feb 17, 2023
@charisk charisk deleted the charisk/cache-schema-validator branch February 17, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees

No one assigned

Labels

secexp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charisk @koesie10