Conversation
Contributor
|
Regarding the changed comments: do we want to advertise both names? |
Contributor
Author
Not sure. I am not super familiar with the context for the change, but I found it odd to refer to a specific name when it could actually be another name. An alternative is to use a less concrete term like "codeql pack file" but often a concrete name is easier to understand. |
norascheuch
approved these changes
Feb 21, 2023
elenatanasoiu
approved these changes
Feb 21, 2023
Contributor
elenatanasoiu
left a comment
There was a problem hiding this comment.
We support both qlpack.yml and codeql-pack.yml at the moment (see https://github.com/github/vscode-codeql/pull/2054/files). So I think your change is perfect @starcke 👍 Thanks for doing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit changes the name of the generated pack from
qlpack.ymltocodeql-pack.yml.The second commit is a single error message change and some comment changes. I noticed them when doing the change, but I can just revert that commit if we do not want to change it.
Checklist
N/A.
ready-for-doc-reviewlabel there.