Add commands package inside src directory#2148
Merged
Conversation
| describe(CommandManager.name, () => { | ||
| it("can create a command manager", () => { | ||
| const commandManager = new CommandManager(); | ||
| expect(commandManager).not.toBeUndefined(); |
Contributor
There was a problem hiding this comment.
I agree we want a test file for this, but I would argue this is actually testing Typescript functionality rather than something specific to the CommandManager.
We can probably overwrite it later with some more concrete testing (and maybe that's what you were thinking as well?).
Member
Author
There was a problem hiding this comment.
Yes, exactly, this was meant as a test just to have a test, but doesn't actually test anything. When we actually do add tests, we'll remove this test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
packages/commandsdirectory with a stub implementation of aCommandManager, in preparation for implementing this command package.Checklist
ready-for-doc-reviewlabel there.