Remove unnecessary commands from activationEvents

[norascheuch]

VSCode Docs: https://code.visualstudio.com/api/references/activation-events

From the docs: Your extension becomes activated when the Activation Event happens.. This means only commands that can be triggered from the command palette need to be listed in the activationEvents. All other events can only be executed when the extension is already activated.

Checklist

• CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
• Issues have been created for any UI or other user-facing changes made by this pull request.
• [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

[robertbrignull]

According to the linting in my VS Code we can remove quite a few more. I see the ones currently included in this PR are just the ones related to variant analysis.

I think we can remove all of the indicated events? What do you think? Does your VS Code also give these warnings.

[robertbrignull]

We might also be able to remove codeQLDatabases.chooseDatabase. As far as I can tell that command doesn't exist. There are a few codeQLDatabases.chooseDatabaseX for where X is Folder, Achive, Internet, Github. Those commands are also listed and marked as unnecessary, so it's not like there's anything special going on because it's a prefix. I think this is leftover from the command getting renamed or split up and now we can remove it.

[shati-patel]

Just one comment, otherwise LGTM!

---

Re:

According to the linting in my VS Code we can remove quite a few more. I see the ones currently included in this PR are just the ones related to variant analysis.

I think we can remove all of the indicated events? What do you think? Does your VS Code also give these warnings.

This is new from VS Code version 1.74.0, so let's not remove these yet (until we set that as our earliest supported VS Code version). We have an internal issue tracking this 💪🏽

[shati-patel]

Agree with @robertbrignull that onCommand:codeQLDatabases.chooseDatabase can be removed, since it doesn't exist 😄

Suggested change

	"onCommand:codeQL.chooseDatabaseGithub",
	"onCommand:codeQLDatabases.chooseDatabase",
	"onCommand:codeQL.chooseDatabaseGithub",

[norascheuch]

Yes, good catch @robertbrignull! :)

[robertbrignull]

I bow to @shati-patel here 🙇 so please go with her review.