Skip to content

Enable React strict mode#2168

Merged
koesie10 merged 4 commits intomainfrom
koesie10/react-strict-mode
Apr 3, 2023
Merged

Enable React strict mode#2168
koesie10 merged 4 commits intomainfrom
koesie10/react-strict-mode

Conversation

@koesie10
Copy link
Copy Markdown
Member

This enables React strict mode which will print extra warnings to the console when we use certain constructs incorrectly. This does not affect production builds.

See https://beta.reactjs.org/reference/react/StrictMode

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This enables React strict mode which will print extra warnings to the
console when we use certain constructs incorrectly. This does not affect
production builds.

See https://beta.reactjs.org/reference/react/StrictMode
@koesie10 koesie10 requested a review from a team March 13, 2023 15:42
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Has this highlighted any issues?

@koesie10
Copy link
Copy Markdown
Member Author

Nice! Has this highlighted any issues?

No, I haven't seen any logs when just clicking through the variant analysis view.

@koesie10 koesie10 marked this pull request as ready for review March 14, 2023 11:19
@koesie10 koesie10 requested a review from a team as a code owner March 14, 2023 11:19
Base automatically changed from koesie10/react-18 to main April 3, 2023 08:47
@koesie10 koesie10 enabled auto-merge April 3, 2023 09:04
@koesie10 koesie10 merged commit 0af3414 into main Apr 3, 2023
@koesie10 koesie10 deleted the koesie10/react-strict-mode branch April 3, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants