Convert run variant analysis command to new commands package#2171
Merged
Convert run variant analysis command to new commands package#2171
Conversation
koesie10
commented
Mar 14, 2023
| @@ -1,4 +1,5 @@ | |||
| import { CommandManager } from "../packages/commands"; | |||
| import type { Uri } from "vscode"; | |||
Member
Author
There was a problem hiding this comment.
I'd have preferred to not import from vscode in the src/common directory, but importing a type should be fine. We could also create an interface that defines the necessary properties to avoid importing from vscode here, but we'd need to find out which methods on Uri in command arguments are being used. For this command, it's just fsPath, but for others there may be more.
elenatanasoiu
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the run variant analysis commands by an implementation based on the new commands package. There should be no changes in behaviour.
Based on #2157
Checklist
ready-for-doc-reviewlabel there.