Skip to content

Convert run variant analysis command to new commands package#2171

Merged
koesie10 merged 2 commits intomainfrom
koesie10/commands-with-progress
Mar 15, 2023
Merged

Convert run variant analysis command to new commands package#2171
koesie10 merged 2 commits intomainfrom
koesie10/commands-with-progress

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Mar 14, 2023

This replaces the run variant analysis commands by an implementation based on the new commands package. There should be no changes in behaviour.

Based on #2157

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@@ -1,4 +1,5 @@
import { CommandManager } from "../packages/commands";
import type { Uri } from "vscode";
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have preferred to not import from vscode in the src/common directory, but importing a type should be fine. We could also create an interface that defines the necessary properties to avoid importing from vscode here, but we'd need to find out which methods on Uri in command arguments are being used. For this command, it's just fsPath, but for others there may be more.

@koesie10 koesie10 marked this pull request as ready for review March 14, 2023 13:15
@koesie10 koesie10 requested review from a team as code owners March 14, 2023 13:15
Base automatically changed from starcke/commands-registration to main March 15, 2023 13:05
@koesie10 koesie10 enabled auto-merge March 15, 2023 14:44
@koesie10 koesie10 merged commit 019af98 into main Mar 15, 2023
@koesie10 koesie10 deleted the koesie10/commands-with-progress branch March 15, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants