Skip to content

Remove codeQL.openVariantAnalysisQueryFile command #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbrignull merged 2 commits into from
Mar 17, 2023
Merged

Remove codeQL.openVariantAnalysisQueryFile command #2179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34ab409
Remove codeQL.openVariantAnalysisQueryFile command
robertbrignull Mar 15, 2023
29bb7ce
Emit telemetry when opening variant analysis query file
robertbrignull Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions extensions/ql-vscode/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,15 +1216,6 @@ async function activateWithInstalledDistribution(
),
);

ctx.subscriptions.push(
commandRunner(
"codeQL.openVariantAnalysisQueryFile",
async (variantAnalysisId: number) => {
await variantAnalysisManager.openQueryFile(variantAnalysisId);
},
),
);

ctx.subscriptions.push(
commandRunner("codeQL.openReferencedFile", async (selectedQuery: Uri) => {
await openReferencedFile(qs, cliServer, selectedQuery);
Expand Down
3 changes: 1 addition & 2 deletions extensions/ql-vscode/src/query-history/query-history-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,8 +522,7 @@ export class QueryHistoryManager extends DisposableObject {
}

if (finalSingleItem.t === "variant-analysis") {
await commands.executeCommand(
"codeQL.openVariantAnalysisQueryFile",
await this.variantAnalysisManager.openQueryFile(
finalSingleItem.variantAnalysis.id,
);
return;
Expand Down
1 change: 1 addition & 0 deletions extensions/ql-vscode/src/variant-analysis/variant-analysis-view-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ export interface VariantAnalysisViewManager<
getRepoStates(
variantAnalysisId: number,
): Promise<VariantAnalysisScannedRepositoryState[]>;
openQueryFile(variantAnalysisId: number): Promise<void>;
}
5 changes: 1 addition & 4 deletions extensions/ql-vscode/src/variant-analysis/variant-analysis-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,7 @@ export class VariantAnalysisView
);
break;
case "openQueryFile":
void commands.executeCommand(
"codeQL.openVariantAnalysisQueryFile",
this.variantAnalysisId,
);
await this.manager.openQueryFile(this.variantAnalysisId);
break;
case "openQueryText":
void commands.executeCommand(
Expand Down
3 changes: 2 additions & 1 deletion extensions/ql-vscode/src/view/variant-analysis/VariantAnalysis.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { VariantAnalysisLoading } from "./VariantAnalysisLoading";
import { ToVariantAnalysisMessage } from "../../pure/interface-types";
import { vscode } from "../vscode-api";
import { defaultFilterSortState } from "../../pure/variant-analysis-filter-sort";
import { useTelemetryOnChange } from "../common/telemetry";
import { sendTelemetry, useTelemetryOnChange } from "../common/telemetry";

export type VariantAnalysisProps = {
variantAnalysis?: VariantAnalysisDomainModel;
Expand All @@ -25,6 +25,7 @@ const openQueryFile = () => {
vscode.postMessage({
t: "openQueryFile",
});
sendTelemetry("variant-analysis-open-query-file");
};

const openQueryText = () => {
Expand Down