Skip to content

Remove two more internal-only commands#2185

Merged
robertbrignull merged 2 commits intomainfrom
robertbrignull/remove_internal_commands
Mar 20, 2023
Merged

Remove two more internal-only commands#2185
robertbrignull merged 2 commits intomainfrom
robertbrignull/remove_internal_commands

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Removes the codeQL.cancelVariantAnalysis and codeQL.openVariantAnalysisQueryText commands. I've done these two together in one PR since they both also use the approach from #2179.

Check the individual commits for changes relevant to each command. For each one we essentially inline the implementation so we call the method on the variant analysis manager directly instead of going through a command. The only case where we're not already inside a command is when triggered from the variant analysis view, so we add dedicated telemetry to cover that.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested review from a team as code owners March 17, 2023 16:15
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertbrignull robertbrignull merged commit 5b2093d into main Mar 20, 2023
@robertbrignull robertbrignull deleted the robertbrignull/remove_internal_commands branch March 20, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants